Review Request 110208: Fix memleak: make ~DialogShadows delete DialogShadows::Private

Sebastian Kügler sebas at kde.org
Fri Apr 26 20:38:25 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110208/#review31641
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On April 26, 2013, 5:51 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110208/
> -----------------------------------------------------------
> 
> (Updated April 26, 2013, 5:51 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> Fix memleak: make ~DialogShadows delete DialogShadows::Private
> 
> 
> Diffs
> -----
> 
>   plasma/private/dialogshadows.cpp e787fd4ec4e39cab275328b5c69aad716c826788 
>   plasma/private/dialogshadows_p.h a2d62ccbe6be7908e076409fd418f48027e5f5da 
> 
> Diff: http://git.reviewboard.kde.org/r/110208/diff/
> 
> 
> Testing
> -------
> 
> Ran Plasma, without crash, tooltips still work.
> Ran upcoming, Plasma::Dialog-based, Colibri: the change makes Valgrind a bit happier.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130426/90eb51cc/attachment.html>


More information about the Plasma-devel mailing list