Review Request 110176: Change the visual appearance of the composited outline

[Thomas Lübking]

> On April 25, 2013, 9:10 a.m., Marco Martin wrote:
> > seems a nice idea.
> > since the shadow for that item is huge, does take it into account when it resizes the frame? )you would want the frame border, not the shadow more or less aligned with the window size)
> 
> Martin Gräßlin wrote:
>     no the border is not considered, but I think that's just fine. It's nothing you really notice that it is not exactly the same geometry and after all: it's just an outline.

I'd frankly leave the shadow padding to prevent cutting of rounded edges - and eventually dep. on theme stress "this is not a bug" ;-)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110176/#review31539
-----------------------------------------------------------


On April 26, 2013, 6 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110176/
> -----------------------------------------------------------
> 
> (Updated April 26, 2013, 6 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> Change the visual appearance of the composited outline
> 
> Uses widgets/translucentbackground as FrameSvg item to ensure that we
> don't get a huge black square on the screen.
> 
> When bordering a screen edge we disable the border except if all edges
> are bordered. This makes a little bit more clear in the quick tiling case
> what will be the geometry.
> 
> Blur behind the outline does not work as:
> * moving the window generates artefacts
> * moved window needs to be above the outline, but outline needs to be on
>   top of everything. Elevating the moved window results in strange
>   side effects when moving the window "below" a keep above, etc.
> 
> 
> Diffs
> -----
> 
>   kwin/geometry.cpp 5a6786d 
>   kwin/outline.cpp ad3cfc0 
> 
> Diff: http://git.reviewboard.kde.org/r/110176/diff/
> 
> 
> Testing
> -------
> 
> I tried various Plasma theme elements. dialog/* and widgets/background are not useable as there are solid themes.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130426/133606ef/attachment.html>