Review Request 110176: Change the visual appearance of the composited outline

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110176/
-----------------------------------------------------------

(Updated April 26, 2013, 8 a.m.)


Review request for kwin and Plasma.


Changes
-------

elevated the moved window while outline is shown. Please give it a try.


Description
-------

Change the visual appearance of the composited outline

Uses widgets/translucentbackground as FrameSvg item to ensure that we
don't get a huge black square on the screen.

When bordering a screen edge we disable the border except if all edges
are bordered. This makes a little bit more clear in the quick tiling case
what will be the geometry.

Blur behind the outline does not work as:
* moving the window generates artefacts
* moved window needs to be above the outline, but outline needs to be on
  top of everything. Elevating the moved window results in strange
  side effects when moving the window "below" a keep above, etc.


Diffs (updated)
-----

  kwin/geometry.cpp 5a6786d 
  kwin/outline.cpp ad3cfc0 

Diff: http://git.reviewboard.kde.org/r/110176/diff/


Testing
-------

I tried various Plasma theme elements. dialog/* and widgets/background are not useable as there are solid themes.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130426/0d092c8f/attachment.html>