Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110122/
-----------------------------------------------------------

(Updated April 25, 2013, 1:58 p.m.)


Review request for Plasma.


Description
-------

Currently the timeout of the last notification to arrive is used as a basis for hiding the notification display. This means that a notification with a high timeout can get hidden by a new notification arriving with a much lower timeout.

This patch simply changes the behaviour to, when expiring a timer, go back through the stack and display the most recent unexpired timer. If all timers are expired the notification is closed as before.


This addresses bug 318295.
    http://bugs.kde.org/show_bug.cgi?id=318295


Diffs
-----

  plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 2fa1b11 

Diff: http://git.reviewboard.kde.org/r/110122/diff/


Testing
-------

Test script in https://bugs.kde.org/show_bug.cgi?id=318295


Thanks,

James Pike

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130425/01caaa30/attachment.html>