Review Request 110176: Change the visual appearance of the composited outline
Martin Gräßlin
mgraesslin at kde.org
Thu Apr 25 12:40:36 UTC 2013
> On April 25, 2013, 2:29 p.m., Thomas Lübking wrote:
> > It's a definitively visual improvement with many themes (including and esp. air), but eg. (old) oxygen and several others still get me a black overlay that does not much look like a frame or window and with "opaquity" it's (surprise) *opaque* (ie. one side of the screen turns -near- black)
> >
> > http://techbase.kde.org/Development/Tutorials/Plasma/ThemeDetails
> > /translucentbackground.svg: a standard background image for plasmoids that for their nature are bigger and with not much text. In this case a translucent background looks better. It needs the same elements of background.svg in it. If this file is not present, the plasmoids that uses this will use background.svg instead.
> >
> > There's (unfortunately) no explicit requirement on that either this is translucent or exists at all (what will get us the regular "solid" background)
> >
> > For the beginning, i'd strongly recommend to elevate the to-be-tiled window over the "outline".
@Plasma devs: could you please clarify whether there is a theme element which is guaranteed to be translucent?
I'll update the patch with the elevating code.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110176/#review31550
-----------------------------------------------------------
On April 25, 2013, 10:58 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110176/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 10:58 a.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Description
> -------
>
> Change the visual appearance of the composited outline
>
> Uses widgets/translucentbackground as FrameSvg item to ensure that we
> don't get a huge black square on the screen.
>
> When bordering a screen edge we disable the border except if all edges
> are bordered. This makes a little bit more clear in the quick tiling case
> what will be the geometry.
>
> Blur behind the outline does not work as:
> * moving the window generates artefacts
> * moved window needs to be above the outline, but outline needs to be on
> top of everything. Elevating the moved window results in strange
> side effects when moving the window "below" a keep above, etc.
>
>
> Diffs
> -----
>
> kwin/outline.cpp ad3cfc01f6fa29010de6845d6c17a54e59d9474e
>
> Diff: http://git.reviewboard.kde.org/r/110176/diff/
>
>
> Testing
> -------
>
> I tried various Plasma theme elements. dialog/* and widgets/background are not useable as there are solid themes.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130425/983eab73/attachment.html>
More information about the Plasma-devel
mailing list