Review Request 110158: Fix crash in Plasma::Applet::configDialogFinished() in the containment case

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110158/
-----------------------------------------------------------

(Updated April 24, 2013, 6:21 p.m.)


Review request for Plasma and Aaron J. Seigo.


Changes
-------

Fix referenced bug number (previous was a dupe).


Description (updated)
-------

This patch fixes a crash tracked in KDE bug 318806.

94e1d5c (KDE/4.10) exposed a latent crash in Plasma::Applet::configDialogFinished(). configDialogFinished() checks whether the publishUi (the widget network sharing ()) has been initialized by checking whether publishUI.publishCheckbox is not null, however this is a uic-generated pointer, and uic generated classes don't zero-init their member pointers in the constructor. Plasma::Applet attempts to cope with this by initializing publishUI.publishCheckbox to 0 in showConfigurationInterface(), but this isn't run in the containment case, where things move through a signal handled by the shell instead. This patch adds a second zero-initialization of publishCheckbox in the AppletPrivate constructor to handle this case as well. I've chosen to keep the one in showConfigurationInterface() regardless to leave it context-free.

I would like to apply this patch to both the KDE/4.10 and master branches.


This addresses bug 318806.
    http://bugs.kde.org/show_bug.cgi?id=318806


Diffs
-----

  plasma/applet.cpp 9ed62bc 

Diff: http://git.reviewboard.kde.org/r/110158/diff/


Testing
-------


Thanks,

Eike Hein

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130424/b750a0c7/attachment.html>