Review Request 110135: Adjust to new suspend session handling

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/#review31490
-----------------------------------------------------------


Ok, so finally we should be near a solution - we've been doing it totally wrong for ages, and thanks Hrvoje and Lukas for bringing up the problem.

Long story short: Using DBus interfaces is not a good idea at all as we don't guarantee stability for all of them. For actions such as suspend/hibernate, we already have a way to do this in KDELibs: http://api.kde.org/4.x-api/kdelibs-apidocs/tier1/solid/html/namespaceSolid_1_1PowerManagement.html#a7dfbc8eef79e2c16ccae30df6c487fcc . So we should use this instead of DBus.

About resumingFromSuspend, same applies. A signal from PowerManagement::Notifier should instead be used: http://api.kde.org/4.x-api/kdelibs-apidocs/tier1/solid/html/classSolid_1_1PowerManagement_1_1Notifier.html#aad2c04c80d5dcb707a1f9098bc0262bf

So we should definitely change this all over workspace (and, at the same time, make sure all applications do the same).

- Dario Freddi


On April 24, 2013, 11:47 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110135/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 11:47 a.m.)
> 
> 
> Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> Suspend/hibernate are now longer are part of
> org.kde.Solid.PowerManagement interface, so adjusting to new one.
> 
> 
> This addresses bug 318737.
>     http://bugs.kde.org/show_bug.cgi?id=318737
> 
> 
> Diffs
> -----
> 
>   kcontrol/randr/module/randrmonitor.cpp 5a719a4 
>   ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
>   ksmserver/shutdowndlg.cpp 247c877 
>   plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
>   plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
>   plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 
> 
> Diff: http://git.reviewboard.kde.org/r/110135/diff/
> 
> 
> Testing
> -------
> 
> Compiled, actions work now.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130424/8073e0bf/attachment.html>