Review Request 110135: Adjust to new suspend session handling

Lukáš Tinkl lukas at kde.org
Tue Apr 23 22:01:22 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/#review31466
-----------------------------------------------------------



kcontrol/randr/module/randrmonitor.cpp
<http://git.reviewboard.kde.org/r/110135/#comment23445>

    This is still wrong...



plasma/generic/dataengines/time/timeengine.cpp
<http://git.reviewboard.kde.org/r/110135/#comment23446>

    ... same as this, you even removed the final "t" from the service name


- Lukáš Tinkl


On April 23, 2013, 10:26 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110135/
> -----------------------------------------------------------
> 
> (Updated April 23, 2013, 10:26 p.m.)
> 
> 
> Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> Suspend/hibernate are now longer are part of
> org.kde.Solid.PowerManagement interface, so adjusting to new one.
> 
> 
> This addresses bug 318737.
>     http://bugs.kde.org/show_bug.cgi?id=318737
> 
> 
> Diffs
> -----
> 
>   kcontrol/randr/module/randrmonitor.cpp 5a719a4 
>   ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
>   ksmserver/shutdowndlg.cpp 247c877 
>   plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp 6f90006 
>   plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
>   plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 
> 
> Diff: http://git.reviewboard.kde.org/r/110135/diff/
> 
> 
> Testing
> -------
> 
> Compiled, actions work now.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130423/0290e73a/attachment.html>


More information about the Plasma-devel mailing list