Menu branch

[Eike Hein]

Hi again,

had a look at the diffs now. Looking good to me from the code
side, but a couple of thoughts on the UI:

- I think the split is working out as well as we had hoped, but
  the devil is in the details ... on the dialog page:

  - The repetition of "Sorting" between the group box title and
    the combo label looks a little clumsy. How about we go with
    "Sort by:" for the label and drop the "By" from the items?

    This should be mirrored in the context menu submenu name
    then, btw. - bonus: Dolphin does it the same way in its
    View menu, so we gain some extra consistency there. (OTOH,
    the KFileDialog context menu uses "Sorting", raah ...
    still, given that Folder View uses "Sort Icons" right now
    at least we'd get down from three to two.)

  - As mentioned in the earlier mail, I think "Layout:" is too
    technical for that combo label. I'd suggest going with
    "Place in:" or "Arrange in:" and then dropping the "In"
    from the items. Perhaps the second; then there's a nice
    theme going on of verbifying the group box title as the
    main option label.

  - The alignment combo options can be simplified to just
    "Left" and "Right" IMHO.

- The context menu rendition of all this is really unintui-
  tive right now - the "To the Left/Right" options really
  can't be understood without any context. I've mulled
  suggesting adding title actions there, but really I think
  the KISS variant is just to go with two submenus, "Arrange
  In" and "Alignment" (followed by Sort By), with just the
  same entries as in the combos.

- By the way, on the consistency front ... both Dolphin
  and KFileDialog just use a "Descending" checkbox instead
  of giving a choice between Asending and Descending via
  radio buttons or a combo; I think Folder View should
  follow suit.


Cheers,
Eike