Review Request 110029: Fix X pixmap leak in shadow handling code

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110029/
-----------------------------------------------------------

(Updated April 20, 2013, 1:46 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Description
-------

Some X pixmaps were never free-ed. The code got a little bit cleaned up by ensuring that the X Pixmap for the QPixmap is always created. This makes sense as we can be pretty sure that we are on the raster graphics system.


Diffs
-----

  plasma/private/dialogshadows.cpp 481f7bd 

Diff: http://git.reviewboard.kde.org/r/110029/diff/


Testing
-------

Tested locally, but I would prefer if someone else could confirm that the leak is gone.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130420/08eb8e4f/attachment.html>