Review Request 109160: do not truncate list of help options in KRunner
Sebastian Kügler
sebas at kde.org
Thu Apr 18 14:24:39 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109160/#review31245
-----------------------------------------------------------
Ship it!
Note to self: Talked with Aaron, can go in, but sebas has to fw-port it to krunner-qml branch.
- Sebastian Kügler
On Feb. 26, 2013, 1:49 p.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109160/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2013, 1:49 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Show all help options
>
> KRunner's resultview limits the numer of items shown to 50. This makes
> sense when showing runner results, but it also cuts off the list of help
> options, making it incomplete.
>
> Suggested patch adds a parameter to ResultScene::setQueryMatches(...)
> which allows overriding the behaviour, and makes setting the help
> options use this.
>
> Intended for 4.10 and master.
>
>
> Diffs
> -----
>
> krunner/interfaces/default/resultscene.cpp 514c2c8
> krunner/interfaces/default/resultscene.h 4aa4844
> krunner/interfaces/default/interface.cpp 505e0aa
>
> Diff: http://git.reviewboard.kde.org/r/109160/diff/
>
>
> Testing
> -------
>
> Verified that all help options are shown. No visible side-effects.
>
>
> Thanks,
>
> Sebastian Kügler
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130418/daab5ec8/attachment.html>
More information about the Plasma-devel
mailing list