Review Request 110065: fix notifcation plasmoid about some undefined data when retreive data from data engine

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110065/#review31233
-----------------------------------------------------------



plasma/generic/applets/notifications/contents/ui/JobDelegate.qml
<http://git.reviewboard.kde.org/r/110065/#comment23221>

    this is likely to break property binding, so if infoMessage changes (for instance) the string property won't also update.
    
    while it's more verbose in the QML, each of the properties should simply use the full form directly so that property binding can happen, e.g.
    
    label0: jobsSource.data["labelName0"] ? jobsSource.data["labelName0"];



plasma/generic/applets/notifications/contents/ui/JobDelegate.qml
<http://git.reviewboard.kde.org/r/110065/#comment23222>

    there is no point in having "infoMessage" if it is only used in this one place. it just means one more object in the QML (more memory usage, etc)


- Aaron J. Seigo


On April 17, 2013, 4:57 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110065/
> -----------------------------------------------------------
> 
> (Updated April 17, 2013, 4:57 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Current notifications will give quite a lot warning, since jobsSource.data[modelData] might be undefined in the first place.
> 
> And this can also cause label1NameText to be shown as "undefinded: " for a job, this can be reproduced when you do the job of copy a large folder to sftp, the label1 will be undefined when doing the folder creation.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/JobDelegate.qml cf60946 
> 
> Diff: http://git.reviewboard.kde.org/r/110065/diff/
> 
> 
> Testing
> -------
> 
> all related warning is now suppressed, and undefined will not be shown in the same case.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130418/d45fd40e/attachment-0001.html>