Review Request 109995: Tint selected icons in Folder View by highlight color (as Dolphin 2.0)

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109995/#review31063
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On April 13, 2013, 3:14 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109995/
> -----------------------------------------------------------
> 
> (Updated April 13, 2013, 3:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> As of Dolphin 2.0, Dolphin tints the icons of selected file items by the palette's highlight color. This patch adapts the Folder View icon view rendering code to mirror this Dolphin behavior for consistency.
> 
> A similar review request has been filed against KFileItemDelegate: http://git.reviewboard.kde.org/r/109997/
> 
> I would like to apply this patch to both the KDE/4.10 and master branches.
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/iconview.cpp 14c136e 
> 
> Diff: http://git.reviewboard.kde.org/r/109995/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/13/before.png
> After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/13/after.png
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130415/b1db667d/attachment-0001.html>