Review Request 109821: make the DvcsJob async

Commit Hook null at kde.org
Thu Apr 11 10:28:40 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109821/
-----------------------------------------------------------

(Updated April 11, 2013, 10:28 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Description
-------

This patch implements a proper KJob and uses the job as an async when
and where it makes sense.

My opinion about the patch(feel free to ignore it:)
I tried to make all the jobs async but in some cases it was an overhead
and the code was looking bad, so I implemented the execSynchrousnly in order
to emphasize that the job is sync and to have a better result.


Diffs
-----

  plasmate/savesystem/timeline.cpp 4293dae 
  plasmate/savesystem/timeline.h 95e7e97 
  plasmate/savesystem/gitrunner.cpp 7520239 
  plasmate/savesystem/gitrunner.h dfacc5b 
  plasmate/savesystem/dvcsjob.cpp 6f83307 
  plasmate/savesystem/dvcsjob.h 38df371 

Diff: http://git.reviewboard.kde.org/r/109821/diff/


Testing
-------

I haven't found any regressions.


Thanks,

Giorgos Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130411/2ff8d15b/attachment.html>


More information about the Plasma-devel mailing list