Review Request 109946: Fix crash in SortFilterModel::mapRowFromSource()

Commit Hook null at kde.org
Wed Apr 10 14:17:13 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109946/
-----------------------------------------------------------

(Updated April 10, 2013, 2:17 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Marco Martin.


Description
-------

Fix crash in SortFilterModel::mapRowFromSource()

It was not using the correct model to get the source index from the row.


Diffs
-----

  plasma/declarativeimports/core/datamodel.cpp d257e5e5e902c9cfbe8ea46e4914d9fd64ab96ce 
  plasma/declarativeimports/core/tests/sortfiltermodeltest.h 653c001776fc7e4ba41c27460ade385fc98d1b4a 
  plasma/declarativeimports/core/tests/sortfiltermodeltest.cpp 7e7ee795ec86e2c7e002819cb43ce4a24298ae41 

Diff: http://git.reviewboard.kde.org/r/109946/diff/


Testing
-------

Added unit-tests for mapRowFromSource() and mapRowToSource() to verify they work correctly.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130410/44a38e80/attachment.html>


More information about the Plasma-devel mailing list