Review Request 109859: Allow plasmoids to provide fallbacks for themed images
Commit Hook
null at kde.org
Tue Apr 9 19:17:46 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109859/
-----------------------------------------------------------
(Updated April 9, 2013, 7:17 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Description
-------
This adds an extra step to the lookup of SVG images created with the Svg() global function: after looking in images/ in the plasmoid and then in the desktop theme, it looks in theme/$DESKTOP_THEME_NAME and then theme/ in the plasmoid.
This allows plasmoid authors to add images that they want to allow theme authors to override.
Depends on RR 109857
Diffs
-----
plasma/scriptengines/javascript/plasmoid/themedsvg.cpp 9de25a1bad3380ac964685b0516705d906a10592
Diff: http://git.reviewboard.kde.org/r/109859/diff/
Testing
-------
Checked with Now Playing that Svg("nocover") finds "content/images/nocover.svgz" and "content/theme/nocover.svgz" in the plasmoid, and that $KDEDIR/share/apps/desktoptheme/default/nocover.svgz overrides the latter.
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130409/f3f2bf43/attachment.html>
More information about the Plasma-devel
mailing list