Review Request 109878: PlasmaClock - fix remaining compilation warnings

[Michał Dutkiewicz]

> On April 8, 2013, 1:59 p.m., Aaron J. Seigo wrote:
> > libs/plasmaclock/calendartable.cpp, line 888
> > <http://git.reviewboard.kde.org/r/109878/diff/1/?file=131519#file131519line888>
> >
> >     does passing in QVariant() alone not work? would remove the need for the "old" magic string in the if statement that follows.

Won't dropping that string trigger converting also for newly added applets?
But that probably wouldn't be big issue since it's simple comparison only.


- Michał


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109878/#review30670
-----------------------------------------------------------


On April 5, 2013, 6:38 p.m., Michał Dutkiewicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109878/
> -----------------------------------------------------------
> 
> (Updated April 5, 2013, 6:38 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Fix remaining compilation warnings, which required converting string calendar identifier to integer (updated once).
> 
> 
> Diffs
> -----
> 
>   libs/plasmaclock/calendartable.cpp 1da4260 
>   libs/plasmaclock/calendartable.h 8678593 
>   libs/plasmaclock/calendar.cpp 0d85dc5 
>   libs/plasmaclock/calendar.h 028b7c0 
> 
> Diff: http://git.reviewboard.kde.org/r/109878/diff/
> 
> 
> Testing
> -------
> 
> Compiles, converting works.
> 
> 
> Thanks,
> 
> Michał Dutkiewicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130408/44f69b11/attachment.html>