Review Request 109773: New runner that translates words and sentences via Google Translate.

[Maarten De Meyer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109773/#review30382
-----------------------------------------------------------



runners/translator/translatorjob.cpp
<http://git.reviewboard.kde.org/r/109773/#comment22657>

    Instead or removing the user agent you could use something like the mediawiki runner:
    "KDE Plasma Silk; MediaWikiRunner; 1.0"
    
    Silk is a way to integrate online content into the desktop.
    Not that a useragent is really important imho.
    
    ps. (You said you were new) Wait for a maintainer to give a 'ship-it' before pushing. This might take a few days.
    If you don't have commit access ask for the maintainer to push in your place.
    Sorry if you already knew this.


- Maarten De Meyer


On April 3, 2013, 10:51 a.m., David Baum wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109773/
> -----------------------------------------------------------
> 
> (Updated April 3, 2013, 10:51 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> The Runner uses the Google Translate Homepage and supports all languages provided by Google. It doesn't use the API, because it's not free of charge. 
> 
> 
> Diffs
> -----
> 
>   runners/translator/translator.h PRE-CREATION 
>   runners/translator/translator.cpp PRE-CREATION 
>   runners/translator/translatorjob.h PRE-CREATION 
>   runners/translator/translatorjob.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Baum
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130404/371c9cd6/attachment-0001.html>