Review Request 109859: Allow plasmoids to provide fallbacks for themed images

Alex Merry kde at randomguy3.me.uk
Thu Apr 4 17:14:51 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109859/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

This adds an extra step to the lookup of SVG images created with the Svg() global function: after looking in images/ in the plasmoid and then in the desktop theme, it looks in theme/$DESKTOP_THEME_NAME and then theme/ in the plasmoid.
    
This allows plasmoid authors to add images that they want to allow theme authors to override.

Depends on RR 109857


Diffs
-----

  plasma/scriptengines/javascript/plasmoid/themedsvg.cpp 9de25a1bad3380ac964685b0516705d906a10592 

Diff: http://git.reviewboard.kde.org/r/109859/diff/


Testing
-------

Checked with Now Playing that Svg("nocover") finds "content/images/nocover.svgz" and "content/theme/nocover.svgz" in the plasmoid, and that $KDEDIR/share/apps/desktoptheme/default/nocover.svgz overrides the latter.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130404/52962ca9/attachment.html>


More information about the Plasma-devel mailing list