Review Request: Use Product instead of description for device names

[Greg T]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106637/#review19614
-----------------------------------------------------------


What will happen if the device name is invalid i.e. empty. Do we handle this case somewhere in the model?

- Greg T


On Sept. 29, 2012, 8:21 p.m., Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106637/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2012, 8:21 p.m.)
> 
> 
> Review request for Plasma and Viranch Mehta.
> 
> 
> Description
> -------
> 
> The description is useful for when the device is not hotpluggable/removeable, for example to show:
> 96.3 GiB Hard Drive
> 15.1 GiB Hard Drive
> 
> instead of two identical labels.
> 
> But when it comes to removable/hotpluggable we want to show the Product to be able to show:
> 
> Nokia N9
> Nexus 7
> 
> Instead of 
> Portable Media Player
> Portable Media Player
> 
> The difference can be shown also in the attached screenshots.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml b23df45 
> 
> Diff: http://git.reviewboard.kde.org/r/106637/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> before
>   http://git.reviewboard.kde.org/r/106637/s/743/
> after
>   http://git.reviewboard.kde.org/r/106637/s/744/
> 
> 
> Thanks,
> 
> Alex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120930/443f0ffd/attachment.html>