Review Request: add preview thumbnail at color wallpaper config dialog

[Antonis Tsiapaliokas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106626/#review19580
-----------------------------------------------------------



plasma/generic/wallpapers/color/color.h
<http://git.reviewboard.kde.org/r/106626/#comment15571>

    Hello,
    
    I know that this is not part of your patch. But could you remove this whitespace with your patch?


- Antonis Tsiapaliokas


On Sept. 28, 2012, 11:56 p.m., Reza Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106626/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2012, 11:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This is part of my feature plan for 4.10.
> 
> Added preview thumbnail at color wallpaper configuration dialog for each background mode, 
> and removed the background mode combobox. 
> 
> 
> Diffs
> -----
> 
>   plasma/generic/wallpapers/color/CMakeLists.txt 71006ee 
>   plasma/generic/wallpapers/color/backgrounddelegate.h e69de29 
>   plasma/generic/wallpapers/color/backgrounddelegate.cpp e69de29 
>   plasma/generic/wallpapers/color/backgroundlistmodel.h e69de29 
>   plasma/generic/wallpapers/color/backgroundlistmodel.cpp e69de29 
>   plasma/generic/wallpapers/color/color.h a477aa9 
>   plasma/generic/wallpapers/color/color.cpp d696c2d 
>   plasma/generic/wallpapers/color/config.ui d5bf809 
>   plasma/generic/wallpapers/color/itemsview.h e69de29 
>   plasma/generic/wallpapers/color/itemsview.cpp e69de29 
> 
> Diff: http://git.reviewboard.kde.org/r/106626/diff/
> 
> 
> Testing
> -------
> 
> tested against master, worked fine.
> 
> 
> Screenshots
> -----------
> 
> new config dialog
>   http://git.reviewboard.kde.org/r/106626/s/740/
> 
> 
> Thanks,
> 
> Reza Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120929/c59cf1ef/attachment-0001.html>