Review Request: Avoid Calling setFailedToLaunch from Microblog Plasmoid

[Antonis Tsiapaliokas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106622/#review19578
-----------------------------------------------------------



applets/microblog/microblog.cpp
<http://git.reviewboard.kde.org/r/106622/#comment15567>

    There is a small coding style error. The "*" should be next to failureWidget and not in the middle.


- Antonis Tsiapaliokas


On Sept. 28, 2012, 12:57 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106622/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2012, 12:57 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Calling setFailedToLaunch removes all child items which causes lots of trouble down the road. See, e.g., http://bugs.sabayon.org/show_bug.cgi?id=3706
> 
> 
> Diffs
> -----
> 
>   applets/microblog/microblog.cpp 376a3cd 
> 
> Diff: http://git.reviewboard.kde.org/r/106622/diff/
> 
> 
> Testing
> -------
> 
> Assuming you have a microblog plasmoid
> 
> 1. Either remove microblogging library or change the name of the engine in the code
> 2. Restart plasma-desktop
> 
> Before this patch, plasma-desktop would stop loading with SIGSEGV. With this patch, the plasmoid loads without functionallity and with a label saying it failed to load the engine.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120929/e29a6b8f/attachment.html>