Review Request: reuse knewstuff's itemsview class to provide smooth scrolling in wallpaper configuration screen

Reza Shah rshah0385 at kireihana.com
Sun Sep 23 02:19:14 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106536/
-----------------------------------------------------------

(Updated Sept. 23, 2012, 2:19 a.m.)


Review request for Plasma.


Changes
-------

- description updated
- removed attachments
- diff file updated


Description (updated)
-------

This patch add smoothscrolling behaviour to listview in image wallpaper screen,
to improve the behaviour mentioned in this bug: https://bugs.kde.org/show_bug.cgi?id=224198

The codes are from knewstuff itemsview class.

Can this also pushed to 4.9 branch?

PS:not sure how to include itemsview.h and itemsview.cpp in diff file, so i just added as file attachments.


This addresses bug 224198.
    http://bugs.kde.org/show_bug.cgi?id=224198


Diffs (updated)
-----

  plasma/generic/wallpapers/image/CMakeLists.txt 2a4c2a3 
  plasma/generic/wallpapers/image/imageconfig.ui 793f0ea 
  plasma/generic/wallpapers/image/itemsview.h PRE-CREATION 
  plasma/generic/wallpapers/image/itemsview.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/106536/diff/


Testing
-------

tested against master.


Thanks,

Reza Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120923/2b59d5d6/attachment.html>


More information about the Plasma-devel mailing list