Review Request: smooth scroll by mousewheel in SystemSettings

[David Edmundson]

> On Sept. 21, 2012, 11:38 a.m., Ben Cooksley wrote:
> > systemsettings/icons/CategorizedView.cpp, line 51
> > <http://git.reviewboard.kde.org/r/106523/diff/1/?file=86653#file86653line51>
> >
> >     I don't know the specifics of the bug which is being worked around, but would it not be more efficient to set the singleStep property once, in the CategorizedView constructor?

The bug is that inside QAbstractItemView the singleStep is changed by the QAbstractItemView whenever updateGeometries is called (so any window resize etc). It's a pretty silly bug. Hence we have to (re-)set it each time just before we use it.

I'll try and get the proper patch merged upstream too, so we can remove this when Qt5 comes out.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106523/#review19265
-----------------------------------------------------------


On Sept. 21, 2012, 11:26 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106523/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2012, 11:26 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Smooth scroll by mousewheel in SystemSettings
>     
> Work around a bug in Qt, where ScrollByPixel does not work, which makes scrolling in a view with large delegates very jumpy/difficult.
> (the same work around is also used in many other places in KDE, older dolphin, gwenview, knewstuff3..)
> 
> 
> Diffs
> -----
> 
>   systemsettings/icons/CategorizedView.h f2b064f 
>   systemsettings/icons/CategorizedView.cpp 1a2a1d9 
> 
> Diff: http://git.reviewboard.kde.org/r/106523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120922/7bae39f1/attachment.html>