Review Request: Fix repositioning the toolbox when the widgets are locked

Ralf Jung post+kde at ralfj.de
Sat Sep 22 11:04:01 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106457/#review19292
-----------------------------------------------------------


I'd appreciate if someone could have a look at this.
If you don't like temporarily changing the m_movable, I could also change the restore function to optionally ignore m_movable.

- Ralf Jung


On Sept. 16, 2012, 8:29 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106457/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2012, 8:29 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This fixes repositioning the toolbox on screen resize with the widgets being locked. Formerly, the toolbox would stick to its previous position, leaving it totally inaccessible in case the screen shrunk, and leaving it in the wrong shape in case the screen was grown. See the bugreport for further details.
> 
> 
> This addresses bug 302645.
>     http://bugs.kde.org/show_bug.cgi?id=302645
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/toolboxes/internaltoolbox.cpp 2c22b70 
> 
> Diff: http://git.reviewboard.kde.org/r/106457/diff/
> 
> 
> Testing
> -------
> 
> The bug is not reproducible anymore.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120922/18acc38e/attachment-0001.html>


More information about the Plasma-devel mailing list