Review Request: Fix panel redraw after screen resize

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106519/#review19273
-----------------------------------------------------------

Ship it!


Obviously not a beauty queen, but so is X. I don't see any other way to fix this, and your patch looks clean.

Please submit to KDE/4.9 and master.

- Sebastian Kügler


On Sept. 21, 2012, 3:57 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106519/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2012, 3:57 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch is my attempt to fix redrawing the panel when the screen is resized. During my experiments, I added update() calls to all places I could think of, but none of them helped - it seems that even though the panel is redrawn, that content is not properly displayed. I am not sure whether this might actually be a bug in KWin: For example, I also saw parts of the panel content end up in the desktop background if compositing was disabled and the background was set to a solid black, opposed to an actual image. I don't have the knowledge to persuade that idea further though.
> I found, however, a solution (or a work-around) to fix the panel bug. Is that acceptable?
> 
> 
> This addresses bug 269635.
>     http://bugs.kde.org/show_bug.cgi?id=269635
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/desktopcorona.h b65a926 
>   plasma/desktop/shell/desktopcorona.cpp ea58c2c 
> 
> Diff: http://git.reviewboard.kde.org/r/106519/diff/
> 
> 
> Testing
> -------
> 
> Re-sized the screen a few times (using xrandr) to verify that the graphical glitches after a resize are gone.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120921/94db2b7a/attachment.html>