Review Request: Fix panel redraw after screen resize

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106519/#review19264
-----------------------------------------------------------



plasma/desktop/shell/panelview.cpp
<http://git.reviewboard.kde.org/r/106519/#comment15266>

    problem with this approach is that whenever it resizes (which happens for many other reasons than screen resizes) it will cause a full panel repaint, and that is very expensive. performance when the panel is resized automatically due to contents changing, for instance, will suffer dramatically.
    
    this needs to be tied to screen size changes ONLY (there is code in the shell that connects to these signals) .. and really it looks like the window just is not properly getting repaint calls when the window is resized in such cases.
    
    i wonder if there isn't a race condition somewhere between screen resizing, panel window resizing and x events somewhere ...


- Aaron J. Seigo


On Sept. 21, 2012, 9:47 a.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106519/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2012, 9:47 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch is my attempt to fix redrawing the panel when the screen is resized. During my experiments, I added update() calls to all places I could think of, but none of them helped - it seems that even though the panel is redrawn, that content is not properly displayed. I am not sure whether this might actually be a bug in KWin: For example, I also saw parts of the panel content end up in the desktop background if compositing was disabled and the background was set to a solid black, opposed to an actual image. I don't have the knowledge to persuade that idea further though.
> I found, however, a solution (or a work-around) to fix the panel bug. Is that acceptable?
> 
> 
> This addresses bug 269635.
>     http://bugs.kde.org/show_bug.cgi?id=269635
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/panelview.cpp 7713740 
> 
> Diff: http://git.reviewboard.kde.org/r/106519/diff/
> 
> 
> Testing
> -------
> 
> Re-sized the screen a few times (using xrandr) to verify that the graphical glitches after a resize are gone.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120921/2f305a87/attachment.html>