Review Request: make plasmate able to load a project in the second time

Giorgos Tsiapaliwkas terietor at gmail.com
Wed Sep 19 11:02:30 UTC 2012



> On Sept. 18, 2012, 11:32 p.m., Aaron J. Seigo wrote:
> > mainwindow.cpp, line 488
> > <http://git.reviewboard.kde.org/r/106479/diff/1/?file=85743#file85743line488>
> >
> >     this looks incorrect; probably what is missing is an "|| !m_part"

it works with !m_part


- Giorgos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106479/#review19136
-----------------------------------------------------------


On Sept. 17, 2012, 11:20 a.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106479/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 11:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> How to reproduce the issue,
> 
> 1. open a project with plasmate
> 2. go File->close project
> 3. open the project again.
> A kmessagebox will appear with the error.
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp b84da4a 
> 
> Diff: http://git.reviewboard.kde.org/r/106479/diff/
> 
> 
> Testing
> -------
> 
> I have tested the patch and I haven't seen any issues
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120919/aa258fc5/attachment.html>


More information about the Plasma-devel mailing list