Review Request: Fix setting the size of the calendar of clocks

Sebastian Kügler sebas at kde.org
Tue Sep 18 22:13:37 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106441/#review19132
-----------------------------------------------------------

Ship it!


Patch looks good now, thanks a lot!

Please commit it to KDE/4.9 and master.

- Sebastian Kügler


On Sept. 18, 2012, 5:40 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106441/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2012, 5:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Currently, the size of the calendar opened when clicking a clock is sometimes set incorrectly, see the bug I linked to this review request. This patch fixes the bug by setting a proper minimal size on the calendar widget and updating the displayed events after configuration changes.
> 
> 
> This addresses bug 306762.
>     http://bugs.kde.org/show_bug.cgi?id=306762
> 
> 
> Diffs
> -----
> 
>   libs/plasmaclock/calendar.cpp 7ea70c2 
> 
> Diff: http://git.reviewboard.kde.org/r/106441/diff/
> 
> 
> Testing
> -------
> 
> I verified that the bug is fixed - everything behaved as expected.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120918/727adc82/attachment.html>


More information about the Plasma-devel mailing list