Review Request: Make it possible to configure a wallpaper from the viewer

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106495/#review19111
-----------------------------------------------------------

Ship it!


Added a few style comments, and a translation improvement. If you change those, feel free to commit.


plasma/generic/tools/wallpaperviewer/main.cpp
<http://git.reviewboard.kde.org/r/106495/#comment15190>

    "Open configuration dialog additionally to showing the wallpaper plugin" would be clearer



plasma/generic/tools/wallpaperviewer/main.cpp
<http://git.reviewboard.kde.org/r/106495/#comment15188>

    Coding style: { and } even for oneliners



plasma/generic/tools/wallpaperviewer/main.cpp
<http://git.reviewboard.kde.org/r/106495/#comment15189>

    whitespace


- Sebastian Kügler


On Sept. 18, 2012, 3:22 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106495/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2012, 3:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Extend the plasmawallpaperviewer with a --configure flag that will show the configure dialog additionally to the wallpaper.
> 
> It's useful because there it's easy to debug the config dialog, I don't know other ways of doing that besides installing+restarting plasma.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/tools/wallpaperviewer/main.cpp ea3c5d4 
>   plasma/generic/tools/wallpaperviewer/wallpaperwidget.h 0f387a5 
> 
> Diff: http://git.reviewboard.kde.org/r/106495/diff/
> 
> 
> Testing
> -------
> 
> I ran it and seemed to work
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120918/494997e4/attachment.html>