Review Request: Device notifier: fix free space information

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106490/#review19106
-----------------------------------------------------------


This review has been submitted with commit b7c7b592e9e48146aa27316fdecd144e1555571f by Alberto Villa to branch KDE/4.9.

- Commit Hook


On Sept. 18, 2012, 12:57 p.m., Alberto Villa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106490/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2012, 12:57 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> The device notifier is using model["Free Space( Text)"] to show information which is not always available. As per Qt documentation, QML models need their roles defined at the beginning, thus, when the plasmoid is loaded with no accessible drives on the system, those two roles are not created (plasma/generic/dataengines/soliddevice/soliddeviceengine.cpp), and the plasmoid will always show "undefined" for its whole lifetime.
> 
> This behaviour isn't observed on Linux apparently, I guess because UDisks always reports some accessible (internal) drives. It might be the same on FreeBSD (which I run), but since my configuration is a bit weird (ZFS), I spotted the bug.
> I reported the problem to Marco Martin and he blogged about it - http://www.notmart.org/index.php/BlaBla/Note_about_QML_plasmoids_and_dat - confirming my analysis.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml 7ac95e7 
>   plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml bf07b10 
> 
> Diff: http://git.reviewboard.kde.org/r/106490/diff/
> 
> 
> Testing
> -------
> 
> With the patch applied, the plasmoid shows space information. The changes were confirmed by Marco Martin in his blog post.
> 
> 
> Thanks,
> 
> Alberto Villa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120918/ddad8983/attachment.html>