*** GMX Spamverdacht *** Re: Review Request: replace old kickoff with kickoff-qml

[Gregor Tätzner]

You mean all of them? We have planned to create a dataengine for adding 
launcher items to the panel but why would you want to expose a 'Sort menu from 
A-Z'? It's strongly tied to the kickoff model.

On Sunday 16 September 2012 00:09:49 Daniel Nicoletti wrote:
> I'll take a look later, but don't you think it's best to expose the context
> menu options as data engines services?
> 
> 2012/9/15 Greg T <yellowcake- at gmx.net>
> 
> >    This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/106448/
> > 
> >   Review request for Plasma and Martin Gräßlin.
> > 
> > By Greg T.
> > 
> > *Updated Sept. 15, 2012, 4:41 p.m.*
> > Changes
> > 
> > I have created a little packagekit dataengine. You can check the status of
> > packagekit and uninstall applications using the provided service.> 
> >   Description
> > 
> > I think it's time now to get the new kickoff into master so we can polish
> > it for KDE 4.10. the qml plasmoid is still using the old model code
> > (though slightly adjusted). This could cause issues for the c++ menu
> > launcher "simpleapplet"...I'm not using it but actually it doesn't even
> > compile. Probably would be better to port it to qml as well...opinions?
> > 
> > The qml code resides in the package dir. It's a pure qml widget with c++
> > model extensions...obviously :)
> > 
> > Add to Panel/Desktop is still not supported but overall I think we have
> > reached feature parity with kickoff c++
> > 
> > I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml.
> > How can we ensure a smooth transition for devs and users?> 
> >   Testing
> > 
> > not too much, surely have to update this diff a couple of times. But you
> > can start dropping comments anyway.> 
> >   Diffs (updated)
> >   
> >    - ksplash/ksplashqml/SplashWindow.cpp
> >    (94e6dedfddcac20516686a7a3b30651d48bc26e7)
> >    - plasma/desktop/applets/kickoff/CMakeLists.txt
> >    (4b0d32a9d0e7d46d05c4efdef9dc39fd653cc2f9)
> >    - plasma/desktop/applets/kickoff/core/CMakeLists.txt (PRE-CREATION)
> >    - plasma/desktop/applets/kickoff/core/applicationmodel.h
> >    (f0f8872255956321292151cdd82326cdf88c5508)
> >    - plasma/desktop/applets/kickoff/core/applicationmodel.cpp
> >    (74b2595ba67de1cdd2f93d3e9e7c2eebd68f6df2)
> >    - plasma/desktop/applets/kickoff/core/favoritesmodel.h
> >    (8ee3e9a9eb16780131d59b150b50641e5a03a34c)
> >    - plasma/desktop/applets/kickoff/core/favoritesmodel.cpp
> >    (14e35cdced82384f0cdf86caec9a4045bfaf2912)
> >    - plasma/desktop/applets/kickoff/core/itemhandlers.h
> >    (ec72cbe51b6e2da604ba6eba96f9e6f3f5935f67)
> >    - plasma/desktop/applets/kickoff/core/itemhandlers.cpp
> >    (4e83c37588af1ebab331082e2eaccb40a0f8155c)
> >    - plasma/desktop/applets/kickoff/core/kickoffabstractmodel.cpp
> >    (7e2e64d22e9e274ffe3d37fdd0ac2c33a622ea3a)
> >    - plasma/desktop/applets/kickoff/core/kickoffmodel.cpp
> >    (8149cac20ce8ab246d8f484ca7567fc6e32d548c)
> >    - plasma/desktop/applets/kickoff/core/kickoffplugin.h (PRE-CREATION)
> >    - plasma/desktop/applets/kickoff/core/kickoffplugin.cpp (PRE-CREATION)
> >    - plasma/desktop/applets/kickoff/core/kickoffproxymodel.cpp
> >    (f92bca971e0f9fcb644cadab6aa39a3e36291c00)
> >    - plasma/desktop/applets/kickoff/core/krunnermodel.h
> >    (93a8b152a673eb6233727a82eefd70739ffc5a0f)
> >    - plasma/desktop/applets/kickoff/core/krunnermodel.cpp
> >    (452ebbe81311f8e3e95b5eda5fb9217344852d06)
> >    - plasma/desktop/applets/kickoff/core/leavemodel.h
> >    (0676fb9358bdfd5e3cffce7eb3a0ea5e4ff70989)
> >    - plasma/desktop/applets/kickoff/core/leavemodel.cpp
> >    (31467acc6654decb2800cf9a5acc398ccaaeccc7)
> >    - plasma/desktop/applets/kickoff/core/models.h
> >    (3332ba9608808b353c32d96c37b84ddd82aabddf)
> >    - plasma/desktop/applets/kickoff/core/models.cpp
> >    (c787df6e2f2c7c88ff97c64c7cd7640cce32365b)
> >    - plasma/desktop/applets/kickoff/core/qmldir (PRE-CREATION)
> >    - plasma/desktop/applets/kickoff/core/recentapplications.h
> >    (a0feddca1cebbeb556623216bcc6c5c30e13a2a4)
> >    - plasma/desktop/applets/kickoff/core/recentapplications.cpp
> >    (3e0538958564ae690e41791bdb5af76fa2ca9a8f)
> >    - plasma/desktop/applets/kickoff/core/recentlyusedmodel.h
> >    (841eb2b77aee778a85c76eafa61d38016f6ade58)
> >    - plasma/desktop/applets/kickoff/core/recentlyusedmodel.cpp
> >    (2762d6d63a7b0592a7e87cd99603cc7c418292c5)
> >    - plasma/desktop/applets/kickoff/core/systemmodel.h
> >    (b04a7871883edd5ea7281d9853ec9203ce019894)
> >    - plasma/desktop/applets/kickoff/core/systemmodel.cpp
> >    (cb9bf650bab36c6415d37db795e766b743d5e25d)
> >    - plasma/desktop/applets/kickoff/core/urlitemlauncher.h
> >    (26b638fc02f42505e29857b5c18736e6778a580e)
> >    - plasma/desktop/applets/kickoff/core/urlitemlauncher.cpp
> >    (75bbfb5a5c6df837e7e56de501156b2ca12ed6d7)
> >    - plasma/desktop/applets/kickoff/package/contents/config/main.xml
> >    (PRE-CREATION)
> >    -
> >    plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qm
> >    l
> >    (PRE-CREATION)
> >    - plasma/desktop/applets/kickoff/package/contents/ui/Breadcrumb.qml
> >    (PRE-CREATION)
> >    - plasma/desktop/applets/kickoff/package/contents/ui/KickoffButton.qml
> >    (PRE-CREATION)
> >    - plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml
> >    (PRE-CREATION)
> >    - plasma/desktop/applets/kickoff/package/contents/ui/MainView.qml
> >    (PRE-CREATION)
> >    - plasma/desktop/applets/kickoff/package/contents/ui/SearchView.qml
> >    (PRE-CREATION)
> >    - plasma/desktop/applets/kickoff/package/contents/ui/config.ui
> >    (PRE-CREATION)
> >    - plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml
> >    (PRE-CREATION)
> >    - plasma/desktop/applets/kickoff/package/metadata.desktop
> >    (PRE-CREATION)
> >    - plasma/generic/dataengines/packagekit/CMakeLists.txt (PRE-CREATION)
> >    - plasma/generic/dataengines/packagekit/packagekit.operations
> >    (PRE-CREATION)
> >    - plasma/generic/dataengines/packagekit/packagekitengine.h
> >    (PRE-CREATION)
> >    - plasma/generic/dataengines/packagekit/packagekitengine.cpp
> >    (PRE-CREATION)
> >    - plasma/generic/dataengines/packagekit/packagekitjob.h (PRE-CREATION)
> >    - plasma/generic/dataengines/packagekit/packagekitjob.cpp
> >    (PRE-CREATION)
> >    - plasma/generic/dataengines/packagekit/packagekitservice.h
> >    (PRE-CREATION)
> >    - plasma/generic/dataengines/packagekit/packagekitservice.cpp
> >    (PRE-CREATION)
> >    -
> >    plasma/generic/dataengines/packagekit/plasma-dataengine-packagekit.des
> >    ktop (PRE-CREATION)
> > 
> > View Diff <http://git.reviewboard.kde.org/r/106448/diff/>
> > 
> > _______________________________________________
> > Plasma-devel mailing list
> > Plasma-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/plasma-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120916/ad413fc9/attachment-0001.sig>