Review Request: Make KDM compilation optional

Martin Gräßlin kde at martin-graesslin.com
Sat Sep 15 09:23:40 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106444/#review18986
-----------------------------------------------------------


given that everything else uses the optional macro that sounds like a valid improvement to me

- Martin Gräßlin


On Sept. 14, 2012, 10:26 a.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106444/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2012, 10:26 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This makes compilation of KDM optional. KDE works fine without KDM using another display manager. and considering that even Plasma is optional, I see no reason for KDM to be mandatory.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 30eb084 
> 
> Diff: http://git.reviewboard.kde.org/r/106444/diff/
> 
> 
> Testing
> -------
> 
> Compiled both with default configuration and with BUILD_kdm=Off, verified that login worked and that the kcm is indeed gone.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120915/792378ff/attachment.html>


More information about the Plasma-devel mailing list