Review Request: Fix setting the size of the calendar of clocks

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106441/#review18976
-----------------------------------------------------------


The user can change the size of the calendar in two ways: 

- when the applet is in a panel / popup by dragging the edges
- when it's on the desktop, using the applet handle

Applying the config changing it to a different size is wrong in both cases. I'm not sure where the bug stems from, but this doesn't look like a good solution to me.


- Sebastian Kügler


On Sept. 13, 2012, 9:27 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106441/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2012, 9:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Currently, the size of the calendar opened when clicking a clock is sometimes set incorrectly, see the bug I linked to this review request. This patch fixes the bug by properly resizing the calendar when changing the settings. As the user can't manually resize the calendar, as and the preferred size seems to be ignored, that look slike the best solution to me.
> 
> 
> This addresses bug 306762.
>     http://bugs.kde.org/show_bug.cgi?id=306762
> 
> 
> Diffs
> -----
> 
>   libs/plasmaclock/calendar.cpp 7ea70c2 
> 
> Diff: http://git.reviewboard.kde.org/r/106441/diff/
> 
> 
> Testing
> -------
> 
> I verified that the bug is fixed - everything behaved as expected.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120914/ded4a109/attachment.html>