Review Request: populate the settings of the rssnow-qml plasmoid

[Giorgos Tsiapaliokas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106582/
-----------------------------------------------------------

(Updated Oct. 30, 2012, 12:39 p.m.)


Review request for Plasma.


Changes
-------

I have fixed the issues..

I have tested the plasmoid in two machines.
In mine it doesn't work well, in the other one it does.

Do we have a third volunteer? :)

P.S.: tomorrow I will clean my system and I will try it.


Description
-------

I have populated the settings of the rssnow-qml plasmoid
and they are identical to the ones of the c++ one.

In order to do that I made the rssnow-qml plasmoid into a hybrid.

After submit of this review I believe that it is ready to be
moved into the kdeplasma-addons and to remove the c++ one.
(I would prefer to open a new review for the move)

Also I have pushed the latest changes(this diff) into the
terietor/rssnow/settings branch in declarative-plasmoids


Diffs (updated)
-----

  rssnow/package/metadata.desktop ef72f15 
  rssnow/plasma-applet-rssnow-qml.desktop ef72f15 
  rssnow/plasma-applet-rssnow.desktop PRE-CREATION 
  rssnow/rssnow.h PRE-CREATION 
  rssnow/rssnow.cpp PRE-CREATION 
  rssnow/feedsConfig.ui PRE-CREATION 
  rssnow/generalConfig.ui PRE-CREATION 
  rssnow/package/contents/config/main.xml e05fcbf 
  rssnow/package/contents/ui/DropRssEntry.qml PRE-CREATION 
  rssnow/package/contents/ui/ListItemEntry.qml 657b14b 
  rssnow/package/contents/ui/config.ui e1e3409 
  rssnow/package/contents/ui/main.qml a575c29 
  rssnow/CMakeLists.txt 79b3581 

Diff: http://git.reviewboard.kde.org/r/106582/diff/


Testing
-------


Thanks,

Giorgos Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121030/40cd2e87/attachment.html>