Review Request: refactor the package model

Giorgos Tsiapaliokas terietor at gmail.com
Tue Oct 30 09:17:44 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106742/
-----------------------------------------------------------

(Updated Oct. 30, 2012, 9:17 a.m.)


Review request for Plasma.


Changes
-------

I have fixed the issues


Description
-------

This patch refactors the package model making it "smarter",

so the package model will
* create only the necessary files and dirs for a package
* a dir is empty it will be auto deleted
* the package model shows the description of the files(if it exists) instead of their names
* if a main.xml file doesn't exist, the model will have an entry like "New Configuration XML",
   the "New..." entry won't be there.


Diffs (updated)
-----

  plasmate/editors/editpage.h 8cc5fab 
  plasmate/editors/editpage.cpp 91f6bce 
  plasmate/mainwindow.cpp 9b38f2b 
  plasmate/packagemodel.h 43b9df5 
  plasmate/packagemodel.cpp 67cc0f4 

Diff: http://git.reviewboard.kde.org/r/106742/diff/


Testing
-------


Thanks,

Giorgos Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121030/c4a493ae/attachment.html>


More information about the Plasma-devel mailing list