Review Request: Convert file content to local encoding before uploading text file in the "share" dataengine

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107044/#review21044
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On Oct. 25, 2012, 8:35 p.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107044/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2012, 8:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> When dragging a text file with utf8 characters to the PasteBin plasma applet, it will upload the file in the wrong encoding. This patch decode the file content using current locale which should be a better option than the default one (Latin1?).
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/share/shareprovider.cpp 81ac677 
> 
> Diff: http://git.reviewboard.kde.org/r/107044/diff/
> 
> 
> Testing
> -------
> 
> Compiled, installed, upload a file with utf8 characters and the encoding is correct.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121028/51c8fd02/attachment.html>