Review Request: Possibility to change an element ID of svg image in IconWidget

[Dmitry Ashkadov]

> On Oct. 25, 2012, 11:36 a.m., Aaron J. Seigo wrote:
> > the real fix here is to not use IconWidget :) that's a QGraphicsWidget thing and will need to be replaced eventually anyways.
> > 
> > this should be using the Button QML element, which does support using SVG files.

IconWidget supports QAction so it's possible to handle global shortcuts. Does QML Button support QAction? Or is is another way to handle global shortcuts from QML?


- Dmitry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107017/#review20863
-----------------------------------------------------------


On Oct. 24, 2012, 1:02 p.m., Dmitry Ashkadov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107017/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2012, 1:02 p.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> -------
> 
> New System tray uses IconWidget QML item, but it isn't possible to set svg image with specified element id. Now I use Svg QML item to load svg and then pass icon to IconWidget, moreover svg is converted to pixmap (: . At the same time IconWidget can handle svg images, so these small changes make me happy :) because I will can eliminate usage of Svg QML items for arrow and Dbus tasks in system tray. 
> 
> 
> Diffs
> -----
> 
>   plasma/widgets/iconwidget.h 78f392e 
>   plasma/widgets/iconwidget.cpp a2092a4 
> 
> Diff: http://git.reviewboard.kde.org/r/107017/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry Ashkadov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121025/6d554a20/attachment.html>