Review Request: Fix ReferenceErrors in ListItem

Aaron J. Seigo aseigo at kde.org
Thu Oct 25 09:28:04 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106937/#review20842
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On Oct. 18, 2012, 2:39 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106937/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2012, 2:39 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
>     Check if referenced objects are valid
>     
>     This kills two ReferenceErrors I'm seeing when using ListItems inside
>     VisualItemModels (in this case, there's no view and visual parent
>     attached on creation).
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/ListItem.qml e352eb0 
> 
> Diff: http://git.reviewboard.kde.org/r/106937/diff/
> 
> 
> Testing
> -------
> 
> tried the news app and widgetgallery, no regressions seen.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121025/6d9a2682/attachment.html>


More information about the Plasma-devel mailing list