Review Request: Fix screenChanged signal in javascript appletinterface
Aaron J. Seigo
aseigo at kde.org
Thu Oct 25 09:27:32 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106936/#review20841
-----------------------------------------------------------
Ship it!
Ship It!
- Aaron J. Seigo
On Oct. 18, 2012, 1 a.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106936/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2012, 1 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Signal/slot signatures were wrong. Correctly forward the screenChanged signal. This removes the following warning for me when running a QML containment in plasmoidviewer:
>
> Object::connect: No such slot ContainmentInterface::screenChanged() in /home/sebas/kdesvn/src/kde/kde-runtime/plasma/scriptengines/javascript/plasmoid/appletinterface.cpp:605
>
>
> Diffs
> -----
>
> plasma/scriptengines/javascript/plasmoid/appletinterface.cpp f2ccf61
>
> Diff: http://git.reviewboard.kde.org/r/106936/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sebastian Kügler
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121025/40c80145/attachment.html>
More information about the Plasma-devel
mailing list