Review Request: Containments expose an AppletContainer

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106817/#review20818
-----------------------------------------------------------

Ship it!


i think this is a good approach.

only thing it can work only until we have only c++ stuff, so toolboxes or applet handles would have to be in a traditional import


plasma/scriptengines/javascript/plasmoid/appletcontainer.h
<http://git.reviewboard.kde.org/r/106817/#comment16438>

    those files should perhaps be in the "declarative" subdirectory in the script engine


- Marco Martin


On Oct. 13, 2012, 12:43 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106817/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2012, 12:43 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
>     This adds a class to manipulate applets in more detail in context of
>     containments. The type will only be available from Containments, not
>     Applets of PopupApplets.
>     
>     This binds the necessary functionality of Applets to build fully
>     features containments. The code has been moved from MobileComponents,
>     untangling another piece there and putting the functionality where it
>     belongs, into the specific component type bindings to allow this functionality 
>     also outside of plasma-mobile and further reduce the delta between the shell 
>     implementations.
> 
>     Intended for kde-runtime master.
> 
> 
> Diffs
> -----
> 
>   plasma/scriptengines/javascript/CMakeLists.txt d259b7f 
>   plasma/scriptengines/javascript/plasmoid/appletcontainer.h PRE-CREATION 
>   plasma/scriptengines/javascript/plasmoid/appletcontainer.cpp PRE-CREATION 
>   plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 46a644a 
> 
> Diff: http://git.reviewboard.kde.org/r/106817/diff/
> 
> 
> Testing
> -------
> 
> The code has been used for some time in Plasma Active, so can be considered stable and well tested. Also tested with a new Containment, works as expected.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121024/8c117f3f/attachment-0001.html>