Review Request: Kickoff-qml fixes

David Edmundson david at davidedmundson.co.uk
Wed Oct 24 18:20:11 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107026/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

If an application has no generic name return the application name as the title.

In this case we return nothing as the subtitle. If the subtitle is the same as the new title, hide the subtitle.
This fixes a bug in which "Find Files" would show with a subtitle but no title as well as "Utilities" having a pointless subtitle
--
Use standard desktop scrolling
--
Always show application subtitle. 

This makes it the same as previous kickoff. This subtitle is quite important when you have two web browsers (for example)
--
Increase padding on LHS between icon and text


Diffs
-----

  plasma/desktop/applets/kickoff/core/applicationmodel.cpp fa5ceea58c4e7e27df1a65d5278510b2d0225ffa 
  plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml 4488f2eaea0bc7447318ca341c5b27d6a4eee700 
  plasma/desktop/applets/kickoff/package/contents/ui/BaseView.qml 2b1e598cc72a84639ecd467ed558276e972a3510 
  plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 9d468b2e596410eae18aba357bd6307b70758e33 

Diff: http://git.reviewboard.kde.org/r/107026/diff/


Testing
-------


Screenshots
-----------

After
  http://git.reviewboard.kde.org/r/107026/s/799/


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121024/86df223a/attachment.html>


More information about the Plasma-devel mailing list