Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.

[Diego Casella]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106999/
-----------------------------------------------------------

(Updated Oct. 22, 2012, 11:01 p.m.)


Review request for Plasma and Marco Martin.


Changes
-------

Updated with screenshots about the other plasma themes from kdeartwork.


Description
-------

When you open the Activity Manager, and click the "Configure" button, the stacked config page displays a misplaced iconButton (see figure on the left).
That's because, in ActivityDelegate, the implicitHeight of the component is forced to 20.
Funny observation: this weird behavior shows up only when Activity Manager is displayed horizontally ... Vertically, everything is just fine.
Anyway the "patch" is just an one-liner so it should be OK, I suppose.
The fixed component is shown in the screenshot on the right.


Diffs
-----

  plasma/desktop/shell/activitymanager/package/contents/ui/ActivityDelegate.qml 4af21e7 

Diff: http://git.reviewboard.kde.org/r/106999/diff/


Testing
-------

Works perfectly, both with horizontal and vertical placement (see shots below).


Screenshots (updated)
-----------

Activity Manager, before
  http://git.reviewboard.kde.org/r/106999/s/790/
Activity Manager, after
  http://git.reviewboard.kde.org/r/106999/s/791/
Activity Manager, Androbit theme
  http://git.reviewboard.kde.org/r/106999/s/792/
Activity Manager, Aya theme
  http://git.reviewboard.kde.org/r/106999/s/793/
Activity Manager, Produkt theme
  http://git.reviewboard.kde.org/r/106999/s/794/
Activity Manager, Slim Glow theme
  http://git.reviewboard.kde.org/r/106999/s/795/
Activity Manager, Tibanna theme
  http://git.reviewboard.kde.org/r/106999/s/796/


Thanks,

Diego Casella

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121022/cd3c1c84/attachment.html>