Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.

[Diego Casella]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106999/
-----------------------------------------------------------

Review request for Plasma and Marco Martin.


Description
-------

When you open the Activity Manager, and click the "Configure" button, the stacked config page displays a misplaced iconButton (see figure on the left).
That's because, in ActivityDelegate, the implicitHeight of the component is forced to 20.
Funny observation: this weird behavior shows up only when Activity Manager is displayed horizontally ... Vertically, everything is just fine.
Anyway the "patch" is just an one-liner so it should be OK, I suppose.
The fixed component is shown in the screenshot on the right.


Diffs
-----

  plasma/desktop/shell/activitymanager/package/contents/ui/ActivityDelegate.qml 4af21e7 

Diff: http://git.reviewboard.kde.org/r/106999/diff/


Testing
-------

Works perfectly, both with horizontal and vertical placement (see shots below).


Screenshots
-----------

Activity Manager, before
  http://git.reviewboard.kde.org/r/106999/s/790/
Activity Manager, after
  http://git.reviewboard.kde.org/r/106999/s/791/


Thanks,

Diego Casella

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121022/7fb9a6b8/attachment-0001.html>