Review Request: load the images for the themes correctly

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106680/#review20680
-----------------------------------------------------------



plasmate/packagemodel.cpp
<http://git.reviewboard.kde.org/r/106680/#comment16331>

    couldn't it just check for the string starting with [plasmate]/themeImageDialog instead of harcoding all these various values? would seem to be a lot more future proof.


- Aaron J. Seigo


On Oct. 4, 2012, 10:49 a.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106680/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 10:49 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> create a new theme package->click on the new
> 
> a file dialog should appear but instead a simple edit box appears requesting a new filename.
> 
> This patch solves the issue
> 
> 
> Diffs
> -----
> 
>   plasmate/editors/editpage.h 8cc5fab 
>   plasmate/editors/editpage.cpp 91f6bce 
>   plasmate/packagemodel.cpp 67cc0f4 
> 
> Diff: http://git.reviewboard.kde.org/r/106680/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121022/c5f6fa95/attachment-0001.html>