Review Request: Implementation of System tray in QML
Dmitry Ashkadov
dmitry.ashkadov at rosalab.ru
Mon Oct 22 09:52:44 UTC 2012
> On Oct. 20, 2012, 11:18 a.m., Marco Martin wrote:
> > plasma/generic/applets/systemtray/ui/wheelarea.h, line 1
> > <http://git.reviewboard.kde.org/r/106965/diff/1/?file=91357#file91357line1>
> >
> > this implementation is not necessary, a wheelevent was added in org.kde.qtextracomponents in MouseEventListener
> >
> > the TODO of replacing this in qt5 stays, but is a c++ file less
> >
> > see http://api.kde.org/4.x-api/kde-runtime-apidocs/plasma/html/classMouseEventListener.html wheelEvent
>
> Dmitry Ashkadov wrote:
> OK, I have replaced WheelArea with MouseEventListener. But I have some questions:
> 1. Does the workflow (http://www.reviewboard.org/docs/manual/1.6/users/getting-started/workflow/) oblige me to update full diff? It may difficalt to find changed in full diff.
> 2. Who have to click on "Fixed"/"Drop" buttons? On the one hand, who requires changes should check changes and apply them or reject, on the second hand, these buttons may notify review about fixed issue.
> 3. Some MouseEventListener's signals give objects named wheel or mouse, but mouse.button/wheel.button have type QVariant, so it's impossible to use switch (mouse.button) { case Qt.LeftButton: ... }. At the same time Qt's MouseArea has different behaviour — switch (mouse.button) { case Qt.RightButton: ... } works
>
> Marco Martin wrote:
> 1) yeah, sometimes is a bit of a mess.. a new diff from master should work tough (if is not possible to make a clean diff, just state that the branch has been updated accordingly)
> 2) for the issues on those comments, you can just mark them as fixed them after you made that change, to signal that.
> 3) that's weird, the mouse event object just exports buttons as Qt::MouseButton enum, like upstream mousearea does, something strange happening at binding level...
>
> anyways, mouseeventlistener should be used just when is really needed something that mousearea can't provide, that at the moment is:
> * wheel
> * screen coordinates for events
> * the main usecase of the class, litening to events that are happening to its children, but without interfering withthem in any way
>
3) I think that the difference in Q_PROPERTY(Qt::MouseButton button). In Qt type int is used instead of Qt::MouseButton: http://qt.gitorious.org/qt/qt/blobs/4.8/src/declarative/graphicsitems/qdeclarativeevents_p_p.h
- Dmitry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106965/#review20597
-----------------------------------------------------------
On Oct. 22, 2012, 9:19 a.m., Dmitry Ashkadov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106965/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2012, 9:19 a.m.)
>
>
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
>
>
> Description
> -------
>
> Implementation of GUI part of System tray in QML. All code accessible from specified branch of kde-workspace
>
>
> Diffs
> -----
>
> plasma/generic/applets/systemtray/CMakeLists.txt d3ce33b
> plasma/generic/applets/systemtray/TODO 257fbe4
> plasma/generic/applets/systemtray/config.h.in aac3113
> plasma/generic/applets/systemtray/core/task.h 31d5949
> plasma/generic/applets/systemtray/core/task.cpp 55c9a1a
> plasma/generic/applets/systemtray/package/contents/ui/ArrowArea.qml PRE-CREATION
> plasma/generic/applets/systemtray/package/contents/ui/IconsGrid.qml PRE-CREATION
> plasma/generic/applets/systemtray/package/contents/ui/IconsList.js PRE-CREATION
> plasma/generic/applets/systemtray/package/contents/ui/IconsList.qml PRE-CREATION
> plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.qml PRE-CREATION
> plasma/generic/applets/systemtray/package/contents/ui/TasksSet.js PRE-CREATION
> plasma/generic/applets/systemtray/package/contents/ui/TrayIcon.qml PRE-CREATION
> plasma/generic/applets/systemtray/package/contents/ui/main.js PRE-CREATION
> plasma/generic/applets/systemtray/package/contents/ui/main.qml PRE-CREATION
> plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.h aa6050e
> plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.cpp f4e8424
> plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h 2847b25
> plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp d4cb309
> plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraywidget.h 0c6daf0
> plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraywidget.cpp 33cf0b1
> plasma/generic/applets/systemtray/protocols/fdo/fdotask.h 4cb5368
> plasma/generic/applets/systemtray/protocols/fdo/fdotask.cpp 69cd625
> plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.h 3e8d120
> plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.cpp 8c1ebba
> plasma/generic/applets/systemtray/ui/applet.h d6cc509
> plasma/generic/applets/systemtray/ui/applet.cpp f3c6d9a
> plasma/generic/applets/systemtray/ui/compactlayout.h c330cee
> plasma/generic/applets/systemtray/ui/compactlayout.cpp e8d02ff
> plasma/generic/applets/systemtray/ui/dialog.h PRE-CREATION
> plasma/generic/applets/systemtray/ui/dialog.cpp PRE-CREATION
> plasma/generic/applets/systemtray/ui/mouseredirectarea.h PRE-CREATION
> plasma/generic/applets/systemtray/ui/mouseredirectarea.cpp PRE-CREATION
> plasma/generic/applets/systemtray/ui/plasmoid.h PRE-CREATION
> plasma/generic/applets/systemtray/ui/plasmoid.cpp PRE-CREATION
> plasma/generic/applets/systemtray/ui/taskarea.h 0e73ead
> plasma/generic/applets/systemtray/ui/taskarea.cpp 4c2d120
> plasma/generic/applets/systemtray/ui/taskarea_p.h fc93661
> plasma/generic/applets/systemtray/ui/taskspool.h PRE-CREATION
> plasma/generic/applets/systemtray/ui/taskspool.cpp PRE-CREATION
> plasma/generic/applets/systemtray/ui/uitask.h PRE-CREATION
> plasma/generic/applets/systemtray/ui/uitask.cpp PRE-CREATION
> plasma/generic/applets/systemtray/ui/widgetitem.h PRE-CREATION
> plasma/generic/applets/systemtray/ui/widgetitem.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/106965/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Example
> http://git.reviewboard.kde.org/r/106965/s/788/
>
>
> Thanks,
>
> Dmitry Ashkadov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121022/e8f4c71c/attachment-0001.html>
More information about the Plasma-devel
mailing list