Review Request: make kickoff-qml partly c++, restores simpleapplet, applet type switch

Marco Martin notmart at gmail.com
Fri Oct 19 13:04:36 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106947/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

this makes the simple laucher work again, and since kickoff is in part c++, the menu editor option as well as the switch from kickoff to classic works again.

main reason of this tough is to eliminate the org.kde.kickoff import, that shouldn't be public api


Diffs
-----

  plasma/desktop/applets/kickoff/CMakeLists.txt 4f61700 
  plasma/desktop/applets/kickoff/applet/applet.h f3afe73 
  plasma/desktop/applets/kickoff/applet/applet.cpp a6f7379 
  plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 4d0e218 
  plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml f953565 
  plasma/desktop/applets/kickoff/package/metadata.desktop 9cb997d 
  plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp 963c18b 
  plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp 28fba18 

Diff: http://git.reviewboard.kde.org/r/106947/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121019/defc4a1a/attachment.html>


More information about the Plasma-devel mailing list