Review Request: make qmlwallpaper thumbnail size similar to other plugins(image, color or pattern plugins)
Aleix Pol Gonzalez
aleixpol at gmail.com
Wed Oct 17 13:04:10 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106927/#review20497
-----------------------------------------------------------
Ship it!
wallpapers/qmlwallpapers/wallpapersqml.cpp
<http://git.reviewboard.kde.org/r/106927/#comment16203>
setting the wallpaper size should reload automatically
wallpapers/qmlwallpapers/wallpapersqml.cpp
<http://git.reviewboard.kde.org/r/106927/#comment16204>
remove whitespace changes?
Thanks for looking into this! :)
Ship it with those fixes :)
- Aleix Pol Gonzalez
On Oct. 17, 2012, 1 p.m., Reza Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106927/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2012, 1 p.m.)
>
>
> Review request for Plasma and Aleix Pol Gonzalez.
>
>
> Description
> -------
>
> this patch will make the thumbnail size in qmlwallpaper config dialog similar to other plugins such as image, color or pattern plugins.
>
>
> Diffs
> -----
>
> wallpapers/qmlwallpapers/wallpapersmodel.h 9cd1d5e
> wallpapers/qmlwallpapers/wallpapersmodel.cpp b29e511
> wallpapers/qmlwallpapers/wallpapersqml.cpp a737027
>
> Diff: http://git.reviewboard.kde.org/r/106927/diff/
>
>
> Testing
> -------
>
> tested against master
>
>
> Thanks,
>
> Reza Shah
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121017/1533b9e8/attachment.html>
More information about the Plasma-devel
mailing list