Review Request: Load and display images in full resolution in imageviewer

Ruediger Gad r.c.g at gmx.de
Tue Oct 16 06:49:15 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106907/
-----------------------------------------------------------

(Updated Oct. 16, 2012, 6:49 a.m.)


Review request for Plasma and Marco Martin.


Description (updated)
-------

In the current state of the image viewer app zoom gestures work.
However, on load the image resolution is set to match the size of the image viewer.
When images are magnified this seems not to be adapted correctly.
Thus, instead of really zooming into an image only larger pixels are displayed.

This patch is an attempt to fix this and allow proper zooming.


Diffs
-----

  applications/filebrowser/imageviewerpart/contents/ui/FullScreenDelegate.qml ba3aea8 

Diff: http://git.reviewboard.kde.org/r/106907/diff/


Testing
-------

Tested this on Archos G9 turbo (2x1.5 GHz, 1 GB RAM).
For testing I used pictures with resolutions up to 11700x1200 pixels.
Load times with this patch applied seemed not to differ from load times without this patch.
In case of very large pictures (see above) the load time was about 0.5 seconds.


Thanks,

Ruediger Gad

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121016/0d6dd897/attachment.html>


More information about the Plasma-devel mailing list