Review Request: Proper fix for DirModel

Ruediger Gad r.c.g at gmx.de
Mon Oct 15 19:24:26 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106901/
-----------------------------------------------------------

(Updated Oct. 15, 2012, 7:24 p.m.)


Review request for Plasma and Marco Martin.


Description
-------

Proper fix to DirModel. The previous fix used quite a hack for getting the URL path of an entity at a given index.
This one implements a generic get method that returns a QVariantMap.
This solution is much more generic as compared to the other hack. Furthermore it can be easily extended when needed.


Diffs
-----

  applications/filebrowser/imageviewerpart/contents/ui/ViewerPage.qml f06969f 
  components/dirmodel/dirmodel.h efd4198 
  components/dirmodel/dirmodel.cpp 2a85ed0 

Diff: http://git.reviewboard.kde.org/r/106901/diff/


Testing
-------

Builds fine and works. Tested on plasma active on Archos g9.


Thanks,

Ruediger Gad

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121015/b5c1eda1/attachment.html>


More information about the Plasma-devel mailing list